8000 bump kic base image by medyagh · Pull Request #9071 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

bump kic base image - #9071

8000
Merged
medyagh merged 2 commits into
kubernetes:masterfrom
medyagh:bump_kic_snap
Aug 25, 2020
Merged

medyagh merged 2 commits into
kubernetes:masterfrom
medyagh:bump_kic_snap

Conversation

@medyagh
@medyagh medyagh commented Aug 24, 2020 •
Copy link
Copy Markdown
Member

Pushed new kic image to include #9029

This PR should be converted to an Auto PR by minikube-bot

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2020
@medyagh medyagh changed the title bump kic base changes bump kic base image Aug 24, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
Comment thread pkg/drivers/kic/types.go
const (
// Version is the current version of kic
Version = "v0.0.12-snapshot"
Version = "v0.0.12-snapshot2"
@tstromberg tstromberg Aug 24, 2020 •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the snapshot name? We should probably stick to SemVer if at possible to be in-line with Kubernetes.

@medyagh medyagh Aug 24, 2020 •
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is before we release. right before we release, we tag the last snapshot as v0.0.12 this way we can safely keep building images on a PR and push it to test it without poulting our offical image with tons of PR pushes v0.0.13 v0.0.14 v0.0.15...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so basically snapshot means current HEAD changes that has not been released to people yet
we can potentially use a different repo too but this pattern seems to straighforward

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to one day automate this process using this pattern #9072

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need some additional identifier too, to distinguish between different images.
Could either use commit (from "git describe") or a date (like KIND is doing) perhaps ?

v1.12.3-153-g5dc6c83
v20200817-222e7545

@TravisBuddy
Copy link
Copy Markdown

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.3 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="39dfa072e472e1cb867478170da377397c5c4c3c" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading k8s.io/apimachinery v0.17.3
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading k8s.io/api v0.17.3
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/spf13/viper v1.7.0
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/miekg/dns v1.1.27
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/spf13/pflag v1.0.5
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/golang/protobuf v1.4.2
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading google.golang.org/protobuf v1.24.0
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading k8s.io/component-base v0.17.3
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
ERROR: logging before flag.Parse: I0824 22:16:25.099674   12164 translate.go:106] Setting Language to en-US ...
--- FAIL: TestGenerateDocs (0.02s)
    --- FAIL: TestGenerateDocs/start (0.01s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   strings.Join({
              	... // 1296 identical bytes
              	"e image to use for docker/podman drivers. Intended for local dev",
              	`elopment. (default "gcr.io/k8s-minikube/kicbase:v0.0.12-snapshot`,
            - 	"2",
              	"@sha256:",
            - 	"2e78dd54231714527631b27e9d6674549d9114d7be1ff55ed417d2bc514a63f4",
            + 	"7be40a42fdfec56fbf7bc9de07ea2ed4a931cbb70dccb8612b2ba13763bf4568",
              	"\")\n      --cache-images                      If true, cache dock",
              	"er images for the current bootstrapper and load them into the ma",
              	... // 9810 identical bytes
              }, "")
E0824 22:16:29.004115   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E0824 22:16:29.004518   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E0824 22:16:29.004613   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=localhost:3128 to docker env.
E0824 22:16:29.004775   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=localhost:3128 to docker env.
E0824 22:16:29.004841   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=http://localhost:3128 to docker env.
E0824 22:16:29.005004   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=http://localhost:3128 to docker env.
E0824 22:16:29.005067   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
E0824 22:16:29.005221   12164 out.go:147] [unset errFile]: ! Not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
FAIL
coverage: 18.6% of statements
FAIL	k8s.io/minikube/cmd/minikube/cmd	3.978s
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.048s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.106s	coverage: 52.5% of statements
ok  	k8s.io/minikube/pkg/drivers	0.013s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.013s	coverage: 3.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.026s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.712s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.107s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.021s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.015s	coverage: 83.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.091s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.019s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.144s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.066s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.028s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.038s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.022s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.041s	coverage: 80.7% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.012s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.042s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.101s	coverage: 36.8% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.047s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.031s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.062s	coverage: 59.3% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.013s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.160s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.012s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.010s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.091s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.014s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.047s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.025s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.009s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.690s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.810s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.005s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
Makefile:292: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: ad6322c0-e657-11ea-aa37-f5f007553843

@medyagh
medyagh commented Aug 24, 2020
Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 24, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9071): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9071/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9071/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9071): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9071/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9071/minikube: exec format error

@tstromberg tstromberg left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the caveat that we should discuss a more meaningful set of versioning.

I would suggest that this in general that we should see about unifying the way that ISO builds & Docker builds function as far as versioning.

@medyagh
medyagh merged commit 616e259 into kubernetes:master Aug 25, 2020
@medyagh
medyagh deleted the bump_kic_snap branch March 2, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0