Repository navigation
bump kic base image - #9071
bump kic base image#9071
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| const ( | ||
| // Version is the current version of kic | ||
| Version = "v0.0.12-snapshot" | ||
| Version = "v0.0.12-snapshot2" |
There was a problem hiding this comment.
What's with the snapshot name? We should probably stick to SemVer if at possible to be in-line with Kubernetes.
There was a problem hiding this comment.
This is before we release. right before we release, we tag the last snapshot as v0.0.12 this way we can safely keep building images on a PR and push it to test it without poulting our offical image with tons of PR pushes v0.0.13 v0.0.14 v0.0.15...
There was a problem hiding this comment.
so basically snapshot means current HEAD changes that has not been released to people yet
we can potentially use a different repo too but this pattern seems to straighforward
There was a problem hiding this comment.
the idea is to one day automate this process using this pattern #9072
There was a problem hiding this comment.
Probably need some additional identifier too, to distinguish between different images.
Could either use commit (from "git describe") or a date (like KIND is doing) perhaps ?
v1.12.3-153-g5dc6c83
v20200817-222e7545
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: ad6322c0-e657-11ea-aa37-f5f007553843 |
|
/ok-to-test |
|
kvm2 Driver |
There was a problem hiding this comment.
Approved with the caveat that we should discuss a more meaningful set of versioning.
I would suggest that this in general that we should see about unifying the way that ISO builds & Docker builds function as far as versioning.
Pushed new kic image to include #9029
This PR should be converted to an Auto PR by minikube-bot