Repository navigation
add an new flag to stop command --keep-context-active - #9044
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: 887f8440-e318-11ea-bb85-f7bf5149087f |
|
Can you describe the use case for this more? I want to make sure this isn't just technical debt. If we really do need this, I would want an integration test for it. |
this is request from multiple IDE teams that they rely on this for a better use experience after minikube is stopped (in context list) |
94d4f89 to
e9cfbd0
Compare
There was a problem hiding this comment.
lgtm, agree that an integration test would be useful
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: 81b276b0-e3d4-11ea-ae1e-a7d25f4a9615 |
Before this PR
After this PR
the context will keep showing as active with new flag --keep-context-active
closes this #9001