8000 GCP Auth Addon: Exit with better error messages by sharifelgamal · Pull Request #8932 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

GCP Auth Addon: Exit 8000 with better error messages - #8932

Merged
sharifelgamal merged 3 commits into
kubernetes:masterfrom
sharifelgamal:gcpauth-warning
Aug 6, 2020
Merged

sharifelgamal merged 3 commits into
kubernetes:masterfrom
sharifelgamal:gcpauth-warning

Conversation

@sharifelgamal
@sharifelgamal sharifelgamal commented Aug 6, 2020 •
Copy link
Copy Markdown
Contributor

This will also make sure the addon doesn't fail if no gcp project is specified, as it's not technically necessary.

It will also suppress unnecessary text when disabling the addon.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
Comment thread pkg/addons/gcpauth/enable.go Resolved
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sharifelgamal
sharifelgamal merged commit 4f8a649 into kubernetes:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0