8000 respect native-ssh flag by sharifelgamal · Pull Request #8907 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

respect native-ssh flag - #8907

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
sharifelgamal:external-ssh
Sep 2, 2020
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
sharifelgamal:external-ssh

Conversation

@sharifelgamal
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 3, 2020
@sharifelgamal
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 3, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add integration test for this

@tstromberg
tstromberg merged commit d66a8e6 into kubernetes:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0