8000 Add stopping as a possible state in deleting, change errorf to warningf by tstromberg · Pull Request #8896 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add stopping as a possible state in deleting, change errorf to warningf - #8896

Merged
sharifelgamal merged 1 commit into
kubernetes:masterfrom
tstromberg:crio-fixes
Jul 31, 2020
Merged

sharifelgamal merged 1 commit into
kubernetes:masterfrom
tstromberg:crio-fixes

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

Removes a possible error log message during deletion.

@tstromberg
tstromberg requested a review from priyawadhwa July 30, 2020 23:12
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2020
@tstromberg
tstromberg requested a review from sharifelgamal July 30, 2020 23:12
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested review from RA489 and medyagh July 30, 2020 23:12
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2020
@medyagh
medyagh commented Jul 31, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 31, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@sharifelgamal
sharifelgamal merged commit bf85c88 into kubernetes:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0