Repository navigation
Add warning for ingress addon enabled with driver of none - #8870
Conversation
|
Hi @Dean-Coakley. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Dean-Coakley The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Travis tests have failedHey @Dean-Coakley, 1st Buildmake testTravisBuddy Request Identifier: cfd684f0-d176-11ea-bb2f-e1a2ee6530fc |
2dc7ae7 to
9c23485
Compare
|
/ok-to-test |
|
kvm2 Driver |
|
@sharifelgamal Excuse my unfamiliarity, Is this PR just pending final review or is there outstanding work I need to do? |
|
Hey @Dean-Coakley, sorry the delay here. Can you fix the addons test (addons_test.go) to not try to enable ingress on none? Right now that test is failing because we're not expecting your new warning message. |
|
Ah looks fixed in: 0afb311 Thanks! |
|
@Dean-Coakley I am using minikube inside LXC with the driver=none and I am having to get back to a version of minikube without this to be able to deploy the nginx ingress controller (which works perfectly in my usecase). Please consider adding a bypass arg like "--skip-none-ingress-check" |
Fixes: #8841
ingress, with the driver ofnone, which is unsupported.Before
After