Repository navigation
WIP: status-ng: support for transition states, errors, warnings - #8813
Closed
tstromberg wants to merge 2 commits into
Closed
tstromberg wants to merge 2 commits into
tstromberg wants to merge 2 commits into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @tstromberg, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: 5f41e090-ccf8-11ea-a3f9-a5c55cea7642 |
Travis tests have failedHey @tstromberg, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: 66774270-cd24-11ea-a3f9-a5c55cea7642 |
Contributor
Author
|
Obsoleted by #8868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8730
Don't expect this code to compile just yet, but here is the TL;DR:
minikube statushas been upgraded to communicate errors and transition statesOld Output
New Output
Old JSON
New JSON
libmachine/statewithminikube/state--compatflag, which will be initially set to true.