8000 Adds support for unsetting of env vars by harkishen · Pull Request #8506 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Adds support for unsetting of env vars - #8506

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
harkishen:unset-docker-podman-env-vars-without-machine-running
Jun 18, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
harkishen:unset-docker-podman-env-vars-without-machine-running

Conversation

@harkishen
@harkishen harkishen commented Jun 17, 2020 •
Copy link
Copy Markdown
Contributor

Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com

Fixes: #8476

Behaviour before this PR

[hsingh@localhost out]$ ./minikube docker-env --unset
🤷  The control plane node must be running for this command
👉  To fix this, run: "minikube start"

Behaviour after this PR

[hsingh@localhost out]$ ./minikube docker-env --unset
unset DOCKER_TLS_VERIFY DOCKER_HOST DOCKER_CERT_PATH MINIKUBE_ACTIVE_DOCKERD

Reference: #8476 (comment)

Explanation:
The unsettling of env-vars in docker should be independent of whether the docker-machine is running or not. This is minikube specific issue and was occurring due co := mustload.Running(cname). Moving the unset statements up, before the running-checks solves the issue. Similar is the situation for podman.

…of running container-machine

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @Harkishen-Singh!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Harkishen-Singh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2020
@harkishen harkishen changed the title Adds support for unsetting of environment variables without the need … Adds support for unsetting of env vars Jun 17, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harkishen-Singh
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@harkishen
Copy link
Copy Markdown
Contributor Author

In reference to #8476 (comment)

@harkishen
Copy link
Copy Markdown
Contributor Author

/assign @medyagh

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harkishen-Singh thank you for this PR, do you mind putting in the PR description the Before and After this PR's output and explain how it is fixing the issue?

@harkishen
harkishen commented Jun 17, 2020 •
Copy link
Copy Markdown
Contributor Author

@medyagh sure.

@harkishen
Copy link
Copy Markdown
Contributor Author

@medyagh Done!

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harkishen-Singh Thank you very much for this helpful PR ! I hope I get to see more contributions from you

@medyagh
medyagh merged commit fe9e0e8 into kubernetes:master Jun 18, 2020
@harkishen
Copy link
Copy Markdown
Contributor Author

@medyagh definitely! Thank you.

@medyagh
medyagh commented Jun 18, 2020 •
Copy link
Copy Markdown
Member

@Harkishen-Singh please feel free to take issues labeled help-wanted or good-first-issue
https://github.com/kubernetes/minikube/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22

@harkishen
Copy link
Copy Markdown
Contributor Author

@medyagh sure.

9D07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minikube docker-env --unset requires minikube to be running

4 participants

0