8000 Bump helm-tiller 2.16.7 and promote tiller ClusterRoleBinding to v1 by govargo · Pull Request #8174 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Bump helm-tiller 2.16.7 and promote tiller ClusterRoleBinding to v1 - #8174

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
govargo:bump-helm-2.16.7
May 18, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
govargo:bump-helm-2.16.7

Conversation

@govargo
@govargo govargo commented May 16, 2020
Copy link
Copy Markdown
Contributor

What type of PR is this?

/area addons

What this PR does / why we need it:

This is small PR.
This bump up helm-tiller addon's image v2.16.3 to v2.16.7 and promote ClusterRoleBinding to v1.

Which issue(s) this PR fixes:

Fixes #8173

Does this PR introduce a user-facing change?

Yes.
This image bumpup includes some helm2 bug fixes.
https://github.com/helm/helm/releases/tag/v2.16.7

Before

image: gcr.io/kubernetes-helm/tiller:v2.16.3

After

image: gcr.io/kubernetes-helm/tiller:v2.16.7

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@govargo
govargo commented May 16, 2020
Copy link
Copy Markdown
Contributor Author

/assign @tstromberg

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #8174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8174   +/-   ##
=======================================
  Coverage   35.27%   35.27%           
=======================================
  Files         146      146           
  Lines        9327     9327           
=======================================
  Hits         3290     3290           
  Misses       5638     5638           
  Partials      399      399           

@medyagh
medyagh 8000 commented May 18, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@medyagh
medyagh merged commit c1e108e into kubernetes:master May 18, 2020
@govargo
govargo deleted the bump-helm-2.16.7 branch February 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump helm-tiller 2.16.7

7 participants

0