8000 fix virtualbox IP address retrieval by sharifelgamal · Pull Request #8106 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

fix virtualbox IP address retrieval - #8106

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
sharifelgamal:vbox
May 13, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
sharifelgamal:vbox

Conversation

@sharifelgamal
@sharifelgamal sharifelgamal commented May 12, 2020 •
Copy link
Copy Markdown
Contributor

Based on #8083

Thanks to @cprogrammer1994 for finding and fixing the issue initially.

Fixes #7993

Before

* minikube v1.10.0 on Microsoft Windows 10 Pro 10.0.18363 Build 18363
* Using the virtualbox driver based on user configuration
* Starting control plane node minikube in cluster minikube
* Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
* Preparing Kubernetes v1.18.1 on Docker 19.03.8 ...
E0512 16:21:31.787931   15788 start.go:95] Unable to get host IP: Error getting VM/Host IP address: Error finding IPV4 address for VirtualBox Host-Only Ethernet Adapter #2
*
X failed to start node: startup failed: Failed to setup kubeconfig: Error getting VM/Host IP address: Error finding IPV4 address for VirtualBox Host-Only Ethernet Adapter #2
*
* minikube is exiting due to an error. If the above message is not useful, open an issue:
  - https://github.com/kubernetes/minikube/issues/new/choose

After

* minikube v1.10.0 on Microsoft Windows 10 Pro 10.0.18363 Build 18363
* Using the virtualbox driver based on user configuration
* Starting control plane node minikube in cluster minikube
* Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
* Preparing Kubernetes v1.18.1 on Docker 19.03.8 ...
* Verifying Kubernetes components...
* Enabled addons: default-storageclass, storage-provisioner
* Done! kubectl is now configured to use "minikube"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@medyagh
medyagh commented May 12, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #8106 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8106      +/-   ##
==========================================
- Coverage   35.35%   35.27%   -0.08%     
==========================================
  Files         146      146              
  Lines        9321     9326       +5     
==========================================
- Hits         3295     3290       -5     
- Misses       5627     5637      +10     
  Partials      399      399              
Impacted Files Coverage Δ
pkg/minikube/cluster/ip.go 0.00% <0.00%> (ø)
pkg/minikube/machine/delete.go 33.92% <0.00%> (-11.36%) ⬇️

@medyagh
medyagh merged commit 522c746 into kubernetes:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

virtualbox on windows: Error VirtualBox Host-Only Ethernet Adapter

5 participants

0