8000 virtualbox: Quiet initial ssh timeout warning by tstromberg · Pull Request #8027 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

virtualbox: Quiet initial ssh timeout warning - #8027

Merged
medyagh merged 2 commits into
kubernetes:masterfrom
tstromberg:quiet-ssh2
May 8, 2020
Merged

medyagh merged 2 commits into
kubernetes:masterfrom
tstromberg:quiet-ssh2

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

On VirtualBox, this issue is apparently a lot more common than I thought.

Fixes #8011

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2020
conn, err := d.Dial("tcp", sshAddr)
if err != nil {
out.WarningT("Unable to verify SSH connectivity: {{.error}}. Will retry...", out.V{"error": err})
glog.Warningf("dial failed (will retry): %v", err)
@medyagh medyagh May 7, 2020 •
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this only causes UI trouble on virtualbox what if we supress UI error only for virtualbox driver? and let other drivers bug us if that happens?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like adding another branch would be over-complicating things with little benefit. If it fails later, an error will be emitted by the ssh runner.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #8027 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8027   +/-   ##
=======================================
  Coverage   35.78%   35.78%           
=======================================
  Files         143      143           
  Lines        9171     9171           
=======================================
  Hits         3282     3282           
  Misses       5489     5489           
  Partials      400      400           
Impacted Files Coverage Δ
cmd/minikube/cmd/stop.go 0.00% <0.00%> (ø)

@medyagh
medyagh merged commit 34e8335 into kubernetes:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestErrorSpam: SSH connectivity: dial tcp 192.168.99.249:22: i/o timeout. Will retry

4 participants

0