Repository navigation
Update ingress-nginx addon - #7997
< 8000 /span>Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@aledbf do you mind sharing the output of using the addon with these changes? |
|
kvm2 Driver |
|
Codecov Report
@@ Coverage Diff @@
## master #7997 +/- ##
=======================================
Coverage 35.78% 35.78%
=======================================
Files 143 143
Lines 9174 9174
=======================================
Hits 3283 3283
Misses 5490 5490
Partials 401 401 |
|
This appears to break the
To debug this, you may find this useful to run:
Maybe the URL mapping changed? |
Thank you for the tip. The error is
This happens because the admission webhook is not available. I added a retry for kubectl command |
Travis tests have failedHey @aledbf, TravisBuddy Request Identifier: fea47810-8e54-11ea-80eb-6b769f7cd14d |
|
@aledbf thanks for the putting the output, btw I like your helper script that u use to create eample ingress I think in a separate PR, I would love to see that as part of a Tutorial on our website. |
|
/retest |
|
kvm2 Driver Times for Minikube (PR 7997): [62.180647117999996 62.374720954000004 63.571860662] Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 7997): [27.045140738 28.42986858500001 28.268166965000002] Averages Time Per Log Details |
|
@tstromberg @medyagh the errors seems not related to the PR. Is there anything else I need to do/check? Thanks |
|
Thank you! |
Uh oh!
There was an error while loading. Please reload this page.