8000 Example how to enable multiple addons on start command by radeksm · Pull Request #7924 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Example how to enable multiple addons on start command - #7924

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
radeksm:bugfix/7920
Apr 29, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
radeksm:bugfix/7920

Conversation

@radeksm
@radeksm radeksm commented Apr 28, 2020
Copy link
Copy Markdown
Contributor

Example how to enable multiple addons on start command

Multiple addons have been added here: #5543
there is a short spec which explains how does it work.

fixes #7920

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @radeksm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeksm
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TravisBuddy
Copy link
Copy Markdown

Travis tests have failed

Hey @radeksm,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b16f4150-8932-11ea-bb83-97d0df38a079

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Copy Markdown
Contributor

Wow, I really don't like this syntax at all. I had assumed comma-delimited worked when I made the name :(

Thank you for documenting it!

@tstromberg tstromberg closed this Apr 29, 2020
@tstromberg tstromberg reopened this Apr 29, 2020
@tstromberg
tstromberg merged commit 135a32f into kubernetes:master Apr 29, 2020
@radeksm
radeksm deleted the bugfix/7920 branch July 21, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify --addons flag syntax

6 participants

0