8000 docker/podman drivers: wait for service before open url by medyagh · Pull Request #7898 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

docker/podman drivers: wait for service before open url - #7898

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
medyagh:svc_url_wait
Apr 25, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
medyagh:svc_url_wait

Conversation

@medyagh
@medyagh medyagh commented Apr 25, 2020 •
Copy link
Copy Markdown
Member

this PR

moves waiting for service before starting kic tunnel

urls, err := service.WaitForService(co.API, co.Config.Name, namespace, svc, serviceURLTemplate, serviceURLMode, https, wait, interval)

closes #7897

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2020
@medyagh medyagh changed the title docker/podman drivers: wait for service before openning docker/podman drivers: wait for service before open url Apr 25, 2020
@medyagh
medyagh requested a review from tstromberg April 25, 2020 02:17
@medyagh
medyagh commented Apr 25, 2020
Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 25, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@medyagh
medyagh merged commit 947dc21 into kubernetes:master Apr 25, 2020
@medyagh
medyagh deleted the svc_url_wait branch May 2, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minikube service should wait for service to be up

4 participants

0