8000 addon registry-alias: change hosts update container image by tmehlinger · Pull Request #7864 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

addon registry-alias: change hosts update container image - #7864

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
tmehlinger:hosts-update-image
Apr 29, 2020
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
tmehlinger:hosts-update-image

Conversation

@tmehlinger
Copy link
Copy Markdown
Contributor

The most recent Fedora image doesn't include a diff binary. This changes the container image to use Ubuntu Bionic instead, which does provide a diff binary.

Fixes #7715.

The most recent Fedora image doesn't include a `diff` binary.
This changes the container image to use Ubuntu Bionic instead,
which _does_ provide a diff binary.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @tmehlinger!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @tmehlinger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmehlinger
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tmehlinger
Copy link
Copy Markdown
Contributor Author

Bump for CLA check.

initContainers:
- name: update
image: registry.fedoraproject.org/fedora
image: ubuntu:bionic
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ubuntu ? could it be something smaller ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason in particular, that was just my workaround. I've changed it to Alpine 3.11 and fixed the diff command to account for the different between Busybox and GNU.

@medyagh medyagh changed the title change hosts update container image addon registry-alias: change hosts update container image Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2020
@RA489
RA489 commented Apr 28, 2020
Copy link
Copy Markdown

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@tstromberg
tstromberg merged commit 541d41f into kubernetes:master Apr 29, 2020
@tstromberg
Copy link
Copy Markdown
Contributor

Thank you!

@tmehlinger
tmehlinger deleted the hosts-update-image branch March 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non- 5A61 member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

registry aliases hosts update fails, diff: command not found

7 participants

0