8000 change emoji for: notifying new kubernetes version is available by radeksm · Pull Request #7835 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

change emoji for: notifying new kubernetes version is available - #7835

Merged
priyawadhwa merged 3 commits into
kubernetes:masterfrom
radeksm:bugdix/7792
Apr 24, 2020
Merged

priyawadhwa merged 3 commits into
kubernetes:masterfrom
radeksm:bugdix/7792

Conversation

@radeksm
@radeksm radeksm commented Apr 21, 2020
Copy link
Copy Markdown
Contributor

Change emoji for telling that new kubernetes is available.

fixes #7792

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @radeksm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeksm
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Comment thread cmd/minikube/cmd/start.go Resolved
@medyagh
medyagh commented Apr 21, 2020
Copy link
Copy Markdown
Member

@radeksm do you mind putting the output before and after this PR ?

@radeksm
radeksm commented Apr 22, 2020
Copy link
Copy Markdown
Contributor Author

@radeksm do you mind putting the output before and after this PR ?

@radeksm do you mind putting the output before and after this PR ?

Here is how it looks like:

[radek@c8k15 ~]$ ./minikube --v=4 --driver=docker --kubernetes-version=v1.17.0 start
😄 minikube v1.10.0-beta.0 on Centos 8.1.1911
✨ Using the docker driver based on user configuration
🆕 Kubernetes 1.18.0 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.0
👍 Starting control plane node minikube in cluster minikube
💾 Downloading Kubernetes v1.17.0 preload ...
> preloaded-images-k8s-v2-v1.17.0-docker-overlay2-amd64.tar.lz4: 539.92 MiB
🔥 Creating docker container (CPUs=2, Memory=1485MB) ...
🐳 Preparing Kubernetes v1.17.0 on Docker 19.03.2 ...

Radoslaw Smigielski added 3 commits April 22, 2020 21:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 22, 2020
@medyagh medyagh changed the title Notify user when new kubernetes version is available change emoji for: notifying new kubernetes version is available Apr 22, 2020
@radeksm
radeksm requested a review from medyagh April 22, 2020 19:55
@radeksm
radeksm commented Apr 23, 2020
Copy link
Copy Markdown
Contributor Author

Unitest failed but failure seems to be unrelated to my change:

2020-04-22T19:55:02.3881542Z --- FAIL: TestNewSSHClient (0.08s)
2020-04-22T19:55:02.3881741Z ssh_mock.go:176: Listening on 127.0.0.1:41431
2020-04-22T19:55:02.3881836Z ssh_mock.go:83: Accepting...
2020-04-22T19:55:02.3881939Z ssh_mock.go:83: Accepting...
2020-04-22T19:55:02.3882079Z ssh_mock.go:135: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc0001ee780 mux:<nil>}
2020-04-22T19:55:02.3882232Z sshutil_test.go:67: Error running "foo": wait: remote command exited without exit status or exit signal
2020-04-22T19:55:02.3882357Z ssh_mock.go:192: Stopping
2020-04-22T19:55:02.3882449Z panic: Fail in goroutine after TestNewSSHClient has completed

@priyawadhwa priyawadhwa left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@priyawadhwa
priyawadhwa merged commit 43948fa into kubernetes:master Apr 24, 2020
@radeksm
radeksm deleted the bugdix/7792 branch July 21, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change emoji for telling that new kubernetes is available

5 participants

0