8000 kic: fix delete -p not cleaning up & add integration test by medyagh · Pull Request #7819 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

< 8000 span class="f1 text-normal markdownTitle__jQX53G prc-Text-Text-9mHv3" data-component="Text">kic: fix delete -p not cleaning up & add integration test - #7819

Merged
medyagh merged 3 commits into
kubernetes:masterfrom
medyagh:fix_delete_bug
Apr 21, 2020
Merged

medyagh merged 3 commits into
kubernetes:masterfrom
medyagh:fix_delete_bug

Conversation

@medyagh
@medyagh medyagh commented Apr 21, 2020 •
Copy link
Copy Markdown
Member

while debugging prelaod putting extra binaries in the tar file, I found out since my kic delete refactor, minikube delete -p doesnt clean up after itself

#7814

but delerte --all works.
added integeration test for it, so it never happens again

@k8s-ci-robot k8s-ci-rob 8000 ot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020
@medyagh medyagh changed the title fix delete and add integeration test kic: fix delete -p not cleaning up & add integration test Apr 21, 2020
@medyagh
medyagh commented Apr 21, 2020
Copy link
Copy Markdown
Member Author
8000

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 21, 2020
@medyagh
medyagh merged commit bfdb710 into kubernetes:master Apr 21, 2020
@medyagh
medyagh deleted the fix_delete_bug branch May 2, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0