8000 do not override hostname if extraConfig is specified by sharifelgamal · Pull Request #7238 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

do not override hostname if extraConfig is specified - #7238

< 8000 div class="d-flex width-full flex-items-start gap-2 flex-column flex-sm-row flex-justify-between">
Merged
sharifelgamal merged 2 commits into
kubernetes:masterfrom
sharifelgamal:honor-override
Mar 25, 2020
Merged

sharifelgamal merged 2 commits into
kubernetes:masterfrom
sharifelgamal:honor-override

Conversation

@sharifelgamal
Copy link
Copy Markdown
Contributor

Fixes #7161

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2020
@sharifelgamal
sharifelgamal requested a review from medyagh March 25, 2020 21:08
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2020
@k8s-ci-robot
k8s-ci-robot requested a review from blueelvis March 25, 2020 21:08
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@medyagh
medyagh commented Mar 25, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 25, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 67.315970 66.261976 65.788317]
All Times Minikube (PR 7238): [ 67.166251 63.854502 62.913095]

Average minikube: 66.455421
Average Minikube (PR 7238): 64.644616

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7238) |
+----------------------+-----------+--------------------+
| minikube v           |  0.133650 |           0.128035 |
| Creating kvm2        | 43.357429 |          41.193255 |
| Preparing Kubernetes | 21.061358 |          21.658666 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@sharifelgamal
sharifelgamal merged commit 7100353 into kubernetes:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to override node-name: lookup minikube on x:53: no such host

5 participants

0