Repository navigation
Conversation
|
Welcome @linkvt! |
|
Hi @linkvt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #7206 +/- ##
==========================================
- Coverage 38.02% 37.93% -0.10%
==========================================
Files 147 147
Lines 9017 9039 +22
==========================================
Hits 3429 3429
- Misses 5164 5186 +22
Partials 424 424
|
|
Thank you! This seems fully reasonable to me. /ok-to-test |
|
Error: running mkcmp: exit status 1 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7206 +/- ##
==========================================
- Coverage 38.02% 37.93% -0.10%
==========================================
Files 147 147
Lines 9017 9039 +22
==========================================
Hits 3429 3429
- Misses 5164 5186 +22
Partials 424 424
🚀 New features to boost your workflow:
|
Hi!
when enabling the istio addon I got the message that I would need more memory in my VM - to my surprise it parsed the
--memory 8gparameter as8000MBand not8192MB.After looking at the rest of the code which uses 1024 in various locations for calculating sizes this seems not intended - I'm of course not sure if this is really the case :).
Detailed Issue Description
As it said I need to give my VM 8192MB I thought that I can just run it with
--memory 8gwhich resulted in 8000MB instead of the expected 8GiB=8192MB:Thanks!
Vincent