8000 hyperv Delete: call StopHost before removing VM by tstromberg · Pull Request #7160 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

hyperv Delete: call StopHost before removing VM - #7160

Merged
tstromberg merged 1 commit into
masterfrom
stop-retry
Mar 23, 2020
Merged

tstromberg merged 1 commit into
masterfrom
stop-retry

Conversation

@tstromberg
@tstromberg tstromberg commented Mar 23, 2020 •
Copy link
Copy Markdown
Contributor

Fixes #6804 - a bug I ran into this morning while running "minikube start/minikube delete" in an infinite loop.

Just in case, it also tries driver deletion twice, since it gets messy if we later delete the machine profile but the VM deletion never happened.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@tstromberg
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 23, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

Comment thread pkg/minikube/machine/delete.go Resolved
@tstromberg
tstromberg merged commit 679b0c6 into master Mar 23, 2020
@medyagh
medyagh deleted the stop-retry branch April 17, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete: The process cannot access the file because it is being used by another process

4 participants

0