8000 Update Nvidia GPU plugin by laozc · Pull Request #7132 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Update Nvidia GPU plugin - #7132

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
laozc:nvidia-gpu
Mar 21, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
laozc:nvidia-gpu

Conversation

@laozc
@laozc laozc commented Mar 21, 2020
Copy link
Copy Markdown
Member

The current plugin used by minikube is too old without properly setting up NVIDIA_VISIBLE_DEVICES for GPU isolation.
Update Nvidia device plugin to latest release to resolve this issue.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2020
@tstromberg
Copy link
Copy Markdown
Contributor

Thank you!

@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@tstromberg
tstromberg merged commit d78f0b1 into kubernetes:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0