8000 Add warning if both vm-driver and driver are specified by priyawadhwa · Pull Request #7109 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add warning if both vm-driver and driver are specified - #7109

Merged
priyawadhwa merged 1 commit into
kubernetes:masterfrom
priyawadhwa:set-vm-driver
Mar 19, 2020
Merged

priyawadhwa merged 1 commit into
kubernetes:masterfrom
priyawadhwa:set-vm-driver

Conversation

@priyawadhwa
@priyawadhwa priyawadhwa commented Mar 19, 2020 •
Copy link
Copy Markdown

New output:

$ minikube start
😄  minikube v1.9.0-beta.1 on Darwin 10.14.6
❗  Both driver=hyperkit and vm-driver=virtualbox have been set.
			
    Since vm-driver is deprecated, minikube will default to driver=hyperkit.

    If vm-driver is set in the global config, please run "minikube config unset vm-driver" to resolve this warning.	
			
✨  Using the hyperkit driver based on user configuration
🔥  Creating hyperkit VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...

Should fix #7091

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #7109 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7109      +/-   ##
==========================================
- Coverage   37.19%   37.17%   -0.03%     
==========================================
  Files         146      146              
  Lines        9106     9112       +6     
==========================================
  Hits         3387     3387              
- Misses       5303     5309       +6     
  Partials      416      416
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 37.31% <0%> (-0.39%) ⬇️

@priyawadhwa
priyawadhwa merged commit c5ceccd into kubernetes:master Mar 19, 2020
@priyawadhwa
priyawadhwa deleted the set-vm-driver branch March 19, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minikube config set vm-driver ignored

5 participants

0