Repository navigation
Conversation
|
Welcome @wallrj! |
|
Hi @wallrj. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
310f4e3 to
bee2907
Compare
|
I compiled minikube locally and verified that it fixes #7028 |
|
/ok-to-test |
|
Error: running mkcmp: exit status 1 |
|
Thank you very much @wallrj for adding this feature in minikube to set controler manager. Your pr looks good to me. |
Thanks. I'm not sure what to do about all the test failures. Are they flakes? I see that these also often fail on master: https://github.com/kubernetes/minikube/commits/master. Is there some way for me to retry these failed tests?
I'm trying to disable the built in CSR signer and replace it with one of my own. See https://github.com/cert-manager/signer-ca/ |
Signed-off-by: Richard Wall richard.wall@jetstack.io
Fixes: #7028