Repository navigation
block on preload download - #7003
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7003 +/- ##
=======================================
Coverage 37.23% 37.23%
=======================================
Files 144 144
Lines 9079 9079
=======================================
Hits 3381 3381
Misses 5272 5272
Partials 426 426 |
|
/ok-to-test |
|
All Times minikube: [ 67.138615 66.353262 66.192287] Average Minikube (PR 7003): 66.673632 Averages Time Per Log |
| glog.Infof("Finished downloading the preloaded tar for %s on %s", k8sVersion, cRuntime) | ||
| return // don't cache individual images if preload is successful. | ||
| } | ||
| glog.Errorf("Error downloading preloaded artifacts will continue without preload: %v", err) |
There was a problem hiding this comment.
Will this result in an error being displayed to the console on older ISO's?
There was a problem hiding this comment.
no this seems to be just downloading it, and it wont untar it yet or anything special
|
All Times minikube: [ 66.099663 62.841955 64.575939] Average minikube: 64.505852 Averages Time Per Log |
before this PR:
"Creating Kubernetes in docker container"...starts while the preload is in progress
while this might be okay in VM world, because VM takes time to warm up but in docker it causes failures.
After this PR: the docker driver will not fail if you purge:
Fixes #7000