8000 Use preloaded tarball for VMs as well by priyawadhwa · Pull Request #6898 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Use preloaded tarball for VMs as well - 8000 #6898

Merged
medyagh merged 13 commits into
kubernetes:masterfrom
priyawadhwa:preloaded-copy-vm
Mar 6, 2020
Merged

medyagh merged 13 commits into
kubernetes:masterfrom
priyawadhwa:preloaded-copy-vm

Conversation

@priyawadhwa
Copy link
Copy Markdown

Since preloaded tarballs are container runtime specific, I added a Preload() func
to the cruntime interface. To use it with VMs, the tarball is first
copied into the VM and then extracted. The leftover tarball is deleted,
and the container runtime (currently only docker is supported) is
restarted.

Priya Wadhwa added 3 commits March 4, 2020 16:17
Since preloaded tarballs are container runtime specific, I added a Preload() func
to the cruntime interface. To use  it with VMs, the tarball is first
copied into the VM and then extracted. The leftover tarball is deleted,
and the container runtime (currently only docker is supported) is
restarted.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@TravisBuddy
Copy link
Copy Markdown

Travis tests have failed

Hey @priyawadhwa,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 614b3760-5f16-11ea-9418-d96fb954c76d

Comment thread pkg/minikube/cruntime/containerd.go Resolved
Comment thread pkg/minikube/cruntime/crio.go Resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2020
@priyawadhwa
Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 5, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 92.092458 94.467348 93.096812]
All Times Minikube (PR 6898): [ 100.579416 98.851705 99.814473]

Average minikube: 93.218873
Average Minikube (PR 6898): 99.748532

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6898) |
+----------------------+-----------+--------------------+
| minikube v           |  0.201396 |           0.219923 |
| Creating kvm2        | 20.318584 |          15.394298 |
| Preparing Kubernetes | 50.308962 |          53.376727 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.028251 |          20.635345 |
| Waiting for cluster  |  0.081244 |           0.063602 |
+----------------------+-----------+--------------------+

Comment thread pkg/minikube/cruntime/docker.go Resolved
Comment thread pkg/minikube/cruntime/docker.go Resolved
@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 94.242589 89.956610 92.616504]
All Times Minikube (PR 6898): [ 97.388704 100.073280 96.997989]

Average minikube: 92.271901
Average Minikube (PR 6898): 98.153324

Averages Time Per Log

+----------------------+-------
8000
----+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6898) |
+----------------------+-----------+--------------------+
| minikube v           |  0.206392 |           0.221772 |
| Creating kvm2        | 19.674527 |          23.635615 |
| Preparing Kubernetes | 49.606402 |          50.366116 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.194019 |          21.098713 |
| Waiting for cluster  |  0.056212 |           0.063058 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming integration tests look reasonable.

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 95.942146 92.820578 95.622671]
All Times Minikube (PR 6898): [ 97.538867 97.261533 96.179786]

Average minikube: 94.795132
Average Minikube (PR 6898): 96.993395

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6898) |
+----------------------+-----------+--------------------+
| minikube v           |  0.222268 |           0.222072 |
| Creating kvm2        | 20.530715 |          22.863609 |
| Preparing Kubernetes | 50.496763 |          50.353372 |
| Pulling images       |           |                    |
| Launching Kubernetes | 22.122011 |          20.218576 |
| Waiting for cluster  |  0.056234 |           0.070332 |
+----------------------+-----------+--------------------+

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6898 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6898     +/-   ##
=========================================
- Coverage   37.11%   37.02%   -0.1%     
=========================================
  Files         144      144             
  Lines        8955     9010     +55     
=========================================
+ Hits         3324     3336     +12     
- Misses       5212     5251     +39     
- Partials      419      423      +4
Impacted Files Coverage Δ
pkg/minikube/cruntime/cruntime.go 57.5% <ø> (ø) ⬆️
pkg/minikube/cruntime/containerd.go 44.54% <0%> (-0.83%) ⬇️
pkg/minikube/cruntime/crio.go 52.04% <0%> (-1.09%) ⬇️
pkg/minikube/cruntime/docker.go 36.55% <0%> (-5.85%) ⬇️
cmd/minikube/cmd/start.go 32.54% <0%> (+0.37%) ⬆️

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 92.242851 95.248294 94.366230]
All Times Minikube (PR 6898): [ 97.548586 97.311726 97.609632]

Average minikube: 93.952459
Average Minikube (PR 6898): 97.489981

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6898) |
+----------------------+-----------+--------------------+
| minikube v           |  0.528522 |           0.207082 |
| Creating kvm2        | 20.163713 |          23.056620 |
| Preparing Kubernetes | 50.138505 |          49.502834 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.800341 |          21.914536 |
| Waiting for cluster  |  0.054175 |           0.071196 |
+----------------------+-----------+--------------------+

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please feel free to merge if tested manually on VM

@medyagh
medyagh merged commit 13d0d3c into kubernetes:master Mar 6, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.02%. Comparing base (ba19967) to head (db9cd9f).
⚠️ Report is 17830 commits behind head on master.

Files with missing lines Patch % Lines
pkg/minikube/cruntime/docker.go 0.00% 20 Missing ⚠️
pkg/minikube/cruntime/containerd.go 0.00% 2 Missing ⚠️
pkg/minikube/cruntime/crio.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6898      +/-   ##
==========================================
- Coverage   37.11%   37.02%   -0.10%     
==========================================
  Files         144      144              
  Lines        8955     9010      +55     
==========================================
+ Hits         3324     3336      +12     
- Misses       5212     5251      +39     
- Partials      419      423       +4     
Files with missing lines Coverage Δ
pkg/minikube/cruntime/cruntime.go 57.50% <ø> (ø)
pkg/minikube/cruntime/containerd.go 44.54% <0.00%> (-0.83%) ⬇️
pkg/minikube/cruntime/crio.go 52.04% <0.00%> (-1.09%) ⬇️
pkg/minikube/cruntime/docker.go 36.55% <0.00%> (-5.85%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

0