8000 Add k8s binaries to preloaded tarball by priyawadhwa · Pull Request #6870 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add k8s binaries to preloaded tarball - #6870

Merged
priyawadhwa merged 1 commit into
kubernetes:masterfrom
priyawadhwa:transfer-binaries
Mar 4, 2020
Merged

priyawadhwa merged 1 commit into
kubernetes:masterfrom
priyawadhwa:transfer-binaries

Conversation

@priyawadhwa
@priyawadhwa priyawadhwa commented Mar 3, 2020 •
Copy link
Copy Markdown

Include k8s binaries in preloaded tarball so that we can skip transferring this over.

This increases the size of the tarball from around 430 MB to 500MB, but saves a couple seconds on start time.

Fixes #6868

Include k8s binaries in preloaded tarball so that we can skip tranferring this over.

This increases the size of the tarball from around 430 MB to 500MB, but saves a couple seconds on start time.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@priyawadhwa
Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 3, 2020
@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 91.345818 91.837129 90.856360]
All Times Minikube (PR 6870): [ 92.131489 92.148339 93.179699]

Average Minikube (PR 6870): 92.486509
Average minikube: 91.346436

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6870) |
+----------------------+-----------+--------------------+
| minikube v           |  0.220132 |           0.218688 |
| Creating kvm2        | 19.736280 |          19.887216 |
| Preparing Kubernetes | 49.436946 |          49.973889 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.748954 |          21.105703 |
| Waiting for cluster  |  0.053950 |           0.089263 |
+----------------------+-----------+--------------------+

@medyagh
medyagh commented Mar 4, 2020
Copy link
Copy Markdown
Member

Looks good to me, please feel free to merge.

@priyawadhwa
priyawadhwa merged commit d403da4 into kubernetes:master Mar 4, 2020
@priyawadhwa
priyawadhwa deleted the transfer-binaries branch March 4, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy in k8s binaries to preloaded tarball so we can skip transfer

4 participants

0