8000 Fix native-ssh flag for the ssh command by afbjorklund · Pull Request #6858 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix native-ssh flag for the ssh command - #6858

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
afbjorklund:ssh-native
Mar 2, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
afbjorklund:ssh-native

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

Closes #6852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@codecov-io
codecov-io commented Mar 2, 2020 •
Copy link
Copy Markdown

Codecov Report

Merging #6858 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6858   +/-   ##
======================================
  Coverage    38.3%   38.3%           
======================================
  Files         142     142           
  Lines        8740    8740           
======================================
  Hits         3348    3348           
  Misses       4971    4971           
  Partials      421     421
Impacted Files Coverage Δ
cmd/minikube/cmd/ssh.go 8.69% <50%> (ø) ⬆️

Comment thread cmd/minikube/cmd/ssh.go

func init() {
sshCmd.Flags().Bool(nativeSSH, true, "Use native Golang SSH client (default true). Set to 'false' to use the command line 'ssh' command when accessing the docker machine. Useful for the machine drivers when they will not start with 'Waiting for SSH'.")
sshCmd.Flags().BoolVar(&nativeSSHClient, nativeSSH, true, "Use native Golang SSH client (default true). Set to 'false' to use the command line 'ssh' command when accessing the docker machine. Useful for the machine drivers when they will not start with 'Waiting for SSH'.")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious if we have other "bool" flags like this that could be fixed the same way ? (if not I am okay with merging this PR)

@starbassma starbassma Mar 2, 2020 •
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is the only one.
Regards

@medyagh
medyagh commented Mar 2, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 2, 2020
@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 92.544333 94.038915 88.240088]
All Times Minikube (PR 6858): [ 90.627899 93.852848 92.270916]

Average minikube: 91.607779
Average Minikube (PR 6858): 92.250555

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6858) |
+----------------------+-----------+--------------------+
| minikube v           |  0.211361 |           0.217522 |
| Creating kvm2        | 20.093604 |          20.112357 |
| Preparing Kubernetes | 48.723139 |          48.881222 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.997408 |          21.082996 |
| Waiting for cluster  |  0.240645 |           0.054184 |
+----------------------+-----------+--------------------+

@medyagh
medyagh merged commit 16388a2 into kubernetes:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to use external ssh client

6 participants

0