Repository navigation
Fix native-ssh flag for the ssh command - #6858
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6858 +/- ##
======================================
Coverage 38.3% 38.3%
======================================
Files 142 142
Lines 8740 8740
======================================
Hits 3348 3348
Misses 4971 4971
Partials 421 421
|
|
|
||
| func init() { | ||
| sshCmd.Flags().Bool(nativeSSH, true, "Use native Golang SSH client (default true). Set to 'false' to use the command line 'ssh' command when accessing the docker machine. Useful for the machine drivers when they will not start with 'Waiting for SSH'.") | ||
| sshCmd.Flags().BoolVar(&nativeSSHClient, nativeSSH, true, "Use native Golang SSH client (default true). Set to 'false' to use the command line 'ssh' command when accessing the docker machine. Useful for the machine drivers when they will not start with 'Waiting for SSH'.") |
There was a problem hiding this comment.
I am curious if we have other "bool" flags like this that could be fixed the same way ? (if not I am okay with merging this PR)
|
/ok-to-test |
|
All Times minikube: [ 92.544333 94.038915 88.240088] Average minikube: 91.607779 Averages Time Per Log |
Closes #6852