8000 kic: fix service list for docker on osx by josedonizetti · Pull Request #6830 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

kic: fix service list for docker o 8000 n osx - #6830

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
josedonizetti:kic-fix-service-list
Feb 28, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
josedonizetti:kic-fix-service-list

Conversation

@josedonizetti
@josedonizetti josedonizetti commented Feb 28, 2020 •
Copy link
Copy Markdown
Contributor

Fix for #6829

./out/minikube service list
|-------------|-----------------|--------------|-----|
|  NAMESPACE  |      NAME       | TARGET PORT  | URL |
|-------------|-----------------|--------------|-----|
| default     | hello-minikube1 |              |     |
| default     | kubernetes      | No node port |
| kube-system | kube-dns        | No node port |
|-------------|-----------------|--------------|-----|

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josedonizetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just could you please paste the output of service list in PR description?

@medyagh
medyagh merged commit 15dfc5c into kubernetes:master Feb 28, 2020
@josedonizetti
josedonizetti deleted the kic-fix-service-list branch February 28, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0