8000 kic on mac: add service cmd support by josedonizetti · Pull Request #6811 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

kic on mac: add service cmd support - #6811

Merged
medyagh merged 6 commits into
kubernetes:masterfrom
josedonizetti:kic-add-cmd-service
Feb 27, 2020
Merged

medyagh merged 6 commits into
kubernetes:masterfrom
josedonizetti:kic-add-cmd-service

Conversation

@josedonizetti
Copy link
Copy Markdown
Contributor

Fix for #6778

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josedonizetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@codecov-io
codecov-io commented Feb 26, 2020 •
Copy link
Copy Markdown

Codecov Report

Merging #6811 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6811      +/-   ##
==========================================
- Coverage   38.43%   38.31%   -0.12%     
==========================================
  Files         142      142              
  Lines        8711     8737      +26     
==========================================
  Hits         3348     3348              
- Misses       4943     4969      +26     
  Partials      420      420
Impacted Files Coverage Δ
cmd/minikube/cmd/service.go 9.85% <0%> (-5.7%) ⬇️

@medyagh medyagh changed the title WIP: kic add service cmd support WIP: kic on mac: add service cmd support Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2020
@medyagh
medyagh commented Feb 27, 2020
Copy link
Copy Markdown
Member

I tried it locally on mac, and it works

$ ./out/minikube service hello-minikube
starting tunnel for hello-minikube
|-----------|----------------|-------------|-----------------------|
| NAMESPACE |      NAME      | TARGET PORT |          URL          |
|-----------|----------------|-------------|-----------------------|
| default   | hello-minikube |             | http://127.0.0.1:8080 |
|-----------|----------------|-------------|-----------------------|
🎉  Opening service default/hello-minikube in default browser...

one suggestion 👍
where it says
🎉 Opening service default/hello-minikube in default browser...
we could add another line

(INFOicon) Because you are using docker driver on Mac, the terminal needs to be open
to run it in background use the following command ...


@josedonizetti josedonizetti changed the title WIP: kic on mac: add service cmd support kic on mac: add service cmd support Feb 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2020
@medyagh
medyagh commented Feb 27, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 27, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@medyagh
medyagh merged commit d19049b into kubernetes:master Feb 27, 2020
@josedonizetti
josedonizetti deleted the kic-add-cmd-service branch February 27, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0