8000 Fix: disabling a disabled addon should not error by sshukun · Pull Request #6817 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix: disabling a disabled addon should not error - # 8000 6817

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
sshukun:fix-addon-disable
Feb 28, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
sshukun:fix-addon-disable

Conversation

@sshukun
@sshukun sshukun commented Feb 27, 2020 •
Copy link
Copy Markdown
Contributor

Fixes #6749
It seems that enabling an enabled addon again is a designed behavior and does not cause error according to #6440.
But disabling a disabled addon will just cause error.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @sshukun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sshukun
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@sshukun
sshukun commented Feb 27, 2020
Copy link
Copy Markdown
Contributor Author

/assign @medyagh
PTAL, thanks

@medyagh
medyagh merged commit 256b90a into kubernetes:master Feb 28, 2020
@medyagh
medyagh commented Feb 28, 2020
Copy link
Copy Markdown
Member

@sshukun thank you for fixing it

@medyagh medyagh changed the title Fix: disable a disabled addon cause error Fix: disable a disabled addon should not error Feb 28, 2020
@medyagh medyagh changed the title Fix: disable a disabled addon should not error Fix: disabling a disabled addon should not error Feb 28, 2020
@sshukun
sshukun deleted the fix-addon-disable branch March 2, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabling an already disabled addon causes error

4 participants

0