8000 fix inverted logic for resource logic by medyagh · Pull Request #6700 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

fix inverted logic for resource logic - # 8000 6700

Merged
medyagh merged 4 commits into
kubernetes:masterfrom
medyagh:resource_limit
Feb 20, 2020
Merged

medyagh merged 4 commits into
kubernetes:masterfrom
medyagh:resource_limit

Conversation

@medyagh
@medyagh medyagh commented Feb 20, 2020 •
Copy link
Copy Markdown
Member

medmac@~/minikube (mount_kic) $ ./out/minikube start --vm-driver=docker -p p2 --memory=2500mb
😄 [p2] minikube v1.7.2 on Darwin 10.13.6
✨ Using the docker (experimental) driver based on user configuration
⚠️ The 'docker' driver does not respect the --memory flag

also the lint issue on master, which travis didnt show on the PR

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2020
@medyagh
medyagh commented Feb 20, 2020
Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2020
@minikube-pr-bot
Copy link
Copy Markdown

All Times Minikube (PR 6700): [ 92.618670 92.048396 93.256389]
All Times minikube: [ 94.169232 93.538831 91.814156]

Average minikube: 93.174073
Average Minikube (PR 6700): 92.641152

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6700) |
+----------------------+-----------+--------------------+
| minikube v           |  0.201532 |           0.201512 |
| Creating kvm2        | 19.633633 |          20.144648 |
| Preparing Kubernetes | 50.032297 |          50.521346 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.150250 |          20.194022 |
| Waiting for cluster  |  0.221437 |           0.046443 |
+----------------------+-----------+--------------------+

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 97.838731 94.397550 91.841780]
All Times Minikube (PR 6700): [ 93.914566 92.302767 92.076160]

Average minikube: 94.692687
Average Minikube (PR 6700): 92.764498

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6700) |
+----------------------+-----------+--------------------+
| minikube v           |  0.206285 |           0.204692 |
| Creating kvm2        | 20.961099 |          20.611489 |
| Preparing Kubernetes | 50.807266 |          48.891314 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.377853 |          20.895166 |
| Waiting for cluster  |  0.051238 |           0.401974 |
+----------------------+-----------+--------------------+

@medyagh
medyagh merged commit 8700f8a into kubernetes:master Feb 20, 2020
@medyagh
medyagh deleted the resource_limit branch May 2, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0