8000 Add --install-addons toggle for users who don't want them by tstromberg · Pull Request #6536 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add --install-addons toggle for users who don't want them - #6536

Merged
priyawadhwa merged 2 commits into
kubernetes:masterfrom
tstromberg:wait-nada2
Feb 7, 2020
Merged

priyawadhwa merged 2 commits into
kubernetes:masterfrom
tstromberg:wait-nada2

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

For embedded use cases that don't need addons, save the user a few seconds.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@codecov-io
codecov-io commented Feb 7, 2020 •
Copy link
Copy Markdown

Codecov Report

Merging #6536 into master will increase coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6536      +/-   ##
==========================================
+ Coverage   37.94%   37.95%   +<.01%     
==========================================
  Files         138      138              
  Lines        8701     8703       +2     
==========================================
+ Hits         3302     3303       +1     
- Misses       4982     4983       +1     
  Partials      417      417
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 22.17% <16.66%> (+0.07%) ⬆️

@medyagh
medyagh commented Feb 7, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 7, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@priyawadhwa
priyawadhwa merged commit 914e7de into kubernetes:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0