8000 Revert role change from cluster-admin->system:persistent-volume-provisioner by tstromberg · Pull Request #6511 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Revert role change from cluster-admin->system:persistent-volume-provisioner - #6511

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
tstromberg:storage-pvc-role
Feb 5, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
tstromberg:storage-pvc-role

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

This reverts part of #6156 that caused a warning to be output when upgrading an old cluster.

Fixes #6510

/cc @nanikjava

@k8s-ci-robot
8000 Copy link
Copy Markdown
Contributor

@tstromberg: GitHub didn't allow me to request PR reviews from the following users: nanikjava.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This reverts part of #6156 that caused a warning to be output when upgrading an old cluster.

Fixes #6510

/cc @nanikjava

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6511   +/-   ##
=======================================
  Coverage   37.95%   37.95%           
=======================================
  Files         138      138           
  Lines        8707     8707           
=======================================
  Hits         3305     3305           
  Misses       4985     4985           
  Partials      417      417

@tstromberg
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@tstromberg
tstromberg merged commit 9be4046 into kubernetes:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

none at head: The ClusterRoleBinding "storage-provisioner" is invalid: cannot change roleRef

4 participants

0