8000 Add docker run-time for kic driver by medyagh · Pull Request #6436 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add docker run-time for kic driver - #6436

Merged
medyagh merged 3 commits into
kubernetes:masterfrom
medyagh:kicind
Jan 30, 2020
Merged

medyagh merged 3 commits into
kubernetes:masterfrom
medyagh:kicind

Conversation

@medyagh
@medyagh medyagh commented Jan 30, 2020 •
Copy link
Copy Markdown
Member

Before this PR:

  • only containerd runtime was supported by kic drivers (docker driver)

After this PR:

  • Add Docker container run time options to Kic Drivers (docker)
  • Remove Auto-setting container runtime to containerd for kic drivers (the default is back to docker)
  • Enable using minikube docker-env

closes #6433

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2020
@medyagh medyagh changed the title Add docker container run time for kic Add docker run-time for kic driver Jan 30, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@medyagh
medyagh commented Jan 30, 2020
Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 30, 2020
@priyawadhwa priyawadhwa left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@priyawadhwa
Copy link
Copy Markdown

/ok-to-test

@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link
Copy Markdown

All Times Minikube (PR 6436): [ 96.332443 95.540018 98.634375]
All Times minikube: [ 96.471956 95.585600 99.143570]

Average minikube: 97.067042
Average Minikube (PR 6436): 96.835612

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6436) |
+----------------------+-----------+--------------------+
| minikube v           |  0.315937 |           0.297529 |
| Creating kvm2        | 20.919686 |          20.486122 |
| Preparing Kubernetes | 48.883252 |          49.287067 |
| Pulling images       |  3.750000 |           3.418858 |
| Launching Kubernetes | 20.420468 |          20.694769 |
| Waiting for cluster  |  2.721584 |           2.596894 |
+----------------------+-----------+--------------------+

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6436 into master will increase coverage by 0.22%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6436      +/-   ##
==========================================
+ Coverage   37.45%   37.68%   +0.22%     
==========================================
  Files         128      128              
  Lines        8648     8654       +6     
==========================================
+ Hits         3239     3261      +22     
+ Misses       4990     4970      -20     
- Partials      419      423       +4
Impacted Files Coverage Δ
pkg/minikube/driver/driver.go 71.83% <ø> (+0.99%) ⬆️
pkg/minikube/cluster/cluster.go 38.26% <53.84%> (+0.08%) ⬆️
pkg/minikube/service/service.go 77.83% <0%> (ø) ⬆️
pkg/minikube/bootstrapper/certs.go 75.51% <0%> (ø) ⬆️
cmd/minikube/cmd/status.go 28.73% <0%> (+21.83%) ⬆️

@medyagh
medyagh merged commit 4bf3fc4 into kubernetes:master Jan 30, 2020
@medyagh
medyagh deleted the kicind branch January 30, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add docker runtime for kic driver

7 participants

0