8000 add container runtime info to profile list by medyagh · Pull Request #6409 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

add container runtime info to profile list - #6409

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
medyagh:plist_cr_info
Jan 31, 2020
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
medyagh:plist_cr_info

Conversation

@medyagh
@medyagh medyagh commented Jan 29, 2020 •
Copy link
Copy Markdown
Member

Before this PR:

|----------|-----------|------------|-----------|--------------------|---------|
| Profile  | VM Driver |   NodeIP   | Node Port | Kubernetes Version | Status  |
|----------|-----------|------------|-----------|--------------------|---------|
| minikube | docker    | 172.17.0.2 |      8443 | v1.17.2            | Running |
|----------|-----------|------------|-----------|--------------------|---------|

After this PR:

|---------|-----------|---------|-------------|------|---------|---------|
| Profile | VM Driver | Runtime |     IP      | Port | Version | Status  |
|---------|-----------|---------|-------------|------|---------|---------|
| p1      | docker    | docker  | 192.168.9.2 | 8443 | v1.17.2 | Running |
|---------|-----------|---------|-------------|------|---------|---------|

closes #6408

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@codecov-io
codecov-io commented Jan 29, 2020 •
Copy link
Copy Markdown

Codecov Report

Merging #6409 into master will increase coverage by 0.21%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6409      +/-   ##
==========================================
+ Coverage   37.46%   37.68%   +0.21%     
==========================================
  Files         128      128              
  Lines        8646     8654       +8     
==========================================
+ Hits         3239     3261      +22     
+ Misses       4988     4970      -18     
- Partials      419      423       +4
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile_list.go 3.94% <0%> (ø) ⬆️
pkg/minikube/cruntime/crunti 8000 me.go 57.5% <0%> (-4.67%) ⬇️
pkg/minikube/service/service.go 77.83% <0%> (ø) ⬆️
pkg/minikube/command/kic_runner.go 0% <0%> (ø) ⬆️
pkg/minikube/bootstrapper/certs.go 75.51% <0%> (ø) ⬆️
pkg/minikube/cluster/cluster.go 38.26% <0%> (+0.08%) ⬆️
pkg/minikube/driver/driver.go 71.83% <0%> (+0.99%) ⬆️
cmd/minikube/cmd/status.go 28.73% <0%> (+21.83%) ⬆️

@medyagh
medyagh commented Jan 29, 2020
Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 29, 2020
@minikube-pr-bot
Copy link
Copy Markdown

Error: running mkcmp: exit status 1

@tstromberg
tstromberg commented Jan 29, 2020 •
Copy link
Copy Markdown
Contributor

Before this PR:

|----------|-----------|------------|-----------|--------------------|---------|
| Profile  | VM Driver |   NodeIP   | Node Port | Kubernetes Version | Status  |
|----------|-----------|------------|-----------|--------------------|---------|
| minikube | docker    | 172.17.0.2 |      8443 | v1.17.2            | Running |
|----------|-----------|------------|-----------|--------------------|---------|

After this PR:

|----------|-----------|-------------------|------------|----------|--------------------|---------|
| Profile  | VM Driver | Container Runtime |   NodeIP   | API Port | Kubernetes Version | Status  |
|----------|-----------|-------------------|------------|----------|--------------------|---------|
| minikube | docker    | containerd        | 172.17.0.2 |     8443 | v1.17.2            | Running |
|----------|-----------|-------------------|------------|----------|--------------------|---------|

closes #6408

Any chance the default output could be adjusted to fit within 80 characters?

@medyagh
medyagh commented Jan 29, 2020
Copy link
Copy Markdown
Member Author

Before this PR:

|----------|-----------|------------|-----------|--------------------|---------|
| Profile  | VM Driver |   NodeIP   | Node Port | Kubernetes Version | Status  |
|----------|-----------|------------|-----------|--------------------|---------|
| minikube | docker    | 172.17.0.2 |      8443 | v1.17.2            | Running |
|----------|-----------|------------|-----------|--------------------|---------|

After this PR:

|----------|-----------|-------------------|------------|----------|--------------------|---------|
| Profile  | VM Driver | Container Runtime |   NodeIP   | API Port | Kubernetes Version | Status  |
|----------|-----------|-------------------|------------|----------|--------------------|---------|
| minikube | docker    | containerd        | 172.17.0.2 |     8443 | v1.17.2            | Running |
|----------|-----------|-------------------|------------|----------|--------------------|---------|

closes #6408

Any chance the default output could be adjusted to fit within 80 characters?

@tstromberg
I was thinking to rename VM Driver to Driver
and rename Container Runtime to Runtime
and Kubernetes Version to Kubernetes Ver
but that wouldn't match the json output...but I am open to suggestions.

the json output is

./out/minikube profile list --output=json
{"invalid":[],"valid":[{"Name":"minikube","Status":"Running","Config":{"Name":"minikube","KeepContext":false,"EmbedCerts":false,"MinikubeISO":"https://storage.googleapis.com/minikube/iso/minikube-v1.7.0-beta.1.iso","Memory":2000,"CPUs":2,"DiskSize":20000,"VMDriver":"docker","HyperkitVpnKitSock":"","HyperkitVSockPorts":[],"DockerEnv":null,"InsecureRegistry":null,"RegistryMirror":null,"HostOnlyCIDR":"192.168.99.1/24","HypervVirtualSwitch":"","KVMNetwork":"default","KVMQemuURI":"qemu:///system","KVMGPU":false,"KVMHidden":false,"DockerOpt":null,"DisableDriverMounts":false,"NFSShare":[],"NFSSharesRoot":"/nfsshares","UUID":"","NoVTXCheck":false,"DNSProxy":false,"HostDNSResolver":true,"HostOnlyNicType":"virtio","NatNicType":"virtio","KubernetesConfig":{"KubernetesVersion":"v1.17.2","APIServerName":"minikubeCA","APIServerNames":null,"APIServerIPs":null,"DNSDomain":"cluster.local","ContainerRuntime":"containerd","CRISocket":"","NetworkPlugin":"cni","FeatureGates":"","ServiceCIDR":"10.96.0.0/12","ImageRepository":"","ExtraOptions":[{"Component":"kubeadm","Key":"pod-network-cidr","Value":"10.244.0.0/16"}],"ShouldLoadCachedImages":true,"EnableDefaultCNI":true},"Nodes":[{"Name":"minikube","IP":"172.17.0.2","Port":8443,"KubernetesVersion":"v1.17.2","ControlPlane":true,"Worker":true}],"Addons":null}}]}

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 95.562088 96.885261 97.012191]
All Times Minikube (PR 6409): [ 98.025026 98.572826 97.273156]

Average minikube: 96.486513
Average Minikube (PR 6409): 97.957003

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6409) |
+----------------------+-----------+--------------------+
| minikube v           |  0.328933 |           0.302319 |
| Creating kvm2        | 20.035454 |          19.847060 |
| Preparing Kubernetes | 49.672747 |          50.471488 |
| Pulling images       |  4.069521 |           3.789453 |
| Launching Kubernetes | 19.602611 |          20.435343 |
| Waiting for cluster  |  2.722943 |           3.057692 |
+----------------------+-----------+--------------------+

@tstromberg
tstromberg merged commit 723b074 into kubernetes:master Jan 31, 2020
@medyagh
medyagh deleted the plist_cr_info branch May 2, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

output container run time in profile list

5 participants

0