8000 Support --force for overriding the ssh check by tstromberg · Pull Request #6237 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Support --force for overriding the ssh check - #6237

Merged
tstromberg merged 4 commits into
kubernetes:masterfrom
tstromberg:ssh-verify
Feb 5, 2020
Merged

tstromberg merged 4 commits into
kubernetes:masterfrom
tstromberg:ssh-verify

Conversation

@tstromberg
@tstromberg tstromberg commented Jan 8, 2020 •
Copy link
Copy Markdown
Contributor

Fixes #6204

This allows you to skip the SSH check if you run minikube start --force (a flag we support for overriding other checks)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@codecov-io
codecov-io commented Jan 8, 2020 •
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@9b5044b). Click here to learn what that means.
The diff coverage is 32.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6237   +/-   ##
=========================================
  Coverage          ?   37.64%           
=========================================
  Files             ?      128           
  Lines             ?     8686           
  Branches          ?        0           
=========================================
  Hits              ?     3270           
  Misses            ?     4991           
  Partials          ?      425
Impacted Files Coverage Δ
cmd/minikube/cmd/mount.go 8.33% <ø> (ø)
pkg/minikube/out/style.go 91.66% <ø> (ø)
pkg/minikube/bootstrapper/bsutil/extraconfig.go 79.1% <ø> (ø)
pkg/util/constants.go 87.5% <ø> (ø)
cmd/minikube/cmd/kubectl.go 0% <ø> (ø)
pkg/minikube/registry/registry.go 100% <ø> (ø)
pkg/minikube/assets/addons.go 37.93% <ø> (ø)
cmd/minikube/cmd/tunnel.go 5.88% <ø> (ø)
pkg/minikube/bootstrapper/bsutil/featuregates.go 84% <ø> (ø)
pkg/minikube/command/exec_runner.go 0% <ø> (ø)
... and 41 more
< 8000 div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none">

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add either to PR description or the docs an example of how to use it

@tstromberg
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2020
@minikube-pr-bot
Copy link
Copy Markdown

All Times Minikube (PR 6237): [ 94.571102 96.973154 95.764858]
All Times minikube: [ 96.563440 97.350948 96.180774]

Average minikube: 96.698387
Average Minikube (PR 6237): 95.769705

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6237) |
+----------------------+-----------+--------------------+
| minikube v           |  0.283800 |           0.288555 |
| Creating kvm2        | 20.352001 |          20.416030 |
| Preparing Kubernetes | 49.897354 |          48.097689 |
| Pulling images       |  3.840533 |           3.696118 |
| Launching Kubernetes | 19.394327 |          20.345526 |
| Waiting for cluster  |  2.879688 |           2.875852 |
+----------------------+-----------+--------------------+

@sharifelgamal
Copy link
Copy Markdown
Contributor

Should we just skip the check entirely if force is passed in, instead of just disregarding the result?

@tstromberg
Copy link
Copy Markdown
Contributor Author

Should we just skip the check entirely if force is passed in, instead of just disregarding the result?

Good call. Done!

@minikube-pr-bot
Copy link
Copy Markdown

All Times minikube: [ 93.897719 92.059437 95.245542]
All Times Minikube (PR 6237): [ 94.917423 91.334774 96.033363]

Average minikube: 93.734232
Average Minikube (PR 6237): 94.095187

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6237) |
+----------------------+-----------+--------------------+
| minikube v           |  0.286343 |           0.280017 |
| Creating kvm2        | 20.195196 |          19.737391 |
| Preparing Kubernetes | 47.906163 |          48.300675 |
| Pulling images       |  3.848618 |           3.891607 |
| Launching Kubernetes | 18.716523 |          19.110764 |
| Waiting for cluster  |  2.730364 |           2.726012 |
+----------------------+-----------+--------------------+

@tstromberg
tstromberg merged commit 37fb104 into kubernetes:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't start minikube with VPN: Unable to verify SSH connectivity

6 participants

0