Repository navigation
Support --force for overriding the ssh check - #6237
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6237 +/- ##
=========================================
Coverage ? 37.64%
=========================================
Files ? 128
Lines ? 8686
Branches ? 0
=========================================
Hits ? 3270
Misses ? 4991
Partials ? 425
|
There was a problem hiding this comment.
Please add either to PR description or the docs an example of how to use it
|
/ok-to-test |
|
All Times Minikube (PR 6237): [ 94.571102 96.973154 95.764858] Average minikube: 96.698387 Averages Time Per Log |
|
Should we just skip the check entirely if force is passed in, instead of just disregarding the result? |
Good call. Done! |
|
All Times minikube: [ 93.897719 92.059437 95.245542] Average minikube: 93.734232 Averages Time Per Log |
Fixes #6204
This allows you to skip the SSH check if you run
minikube start --force(a flag we support for overriding other checks)