Repository navigation
Check for nil ref and img before passing them into go-containerregistry - #6236
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6236 +/- ##
==========================================
- Coverage 38.5% 38.26% -0.24%
==========================================
Files 122 124 +2
Lines 8145 8261 +116
==========================================
+ Hits 3136 3161 +25
- Misses 4600 4690 +90
- Partials 409 410 +1
|
|
/ok-to-test |
|
All Times minikube: [ 123.504306 124.749722 123.867602] Average minikube: 124.040543 Averages Time Per Log |
|
All Times Minikube (PR 6236): [ 113.510606 122.009113 122.786632] Average minikube: 119.516619 Averages Time Per Log |
|
/retest this please |
|
Error: running mkcmp: exit status 1 |
|
|
||
| // saveToTarFile caches an image | ||
| func saveToTarFile(image, dst string) error { | ||
| func saveToTarFile(iname, dst string) error { |
|
/retest this please |
May fix #6147