Repository navigation
Offline: always transfer image if lookup fails, always download drivers - #6111
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6111 +/- ##
=========================================
- Coverage 36.7% 36.7% -0.01%
=========================================
Files 113 113
Lines 8355 8356 +1
=========================================
Hits 3067 3067
- Misses 4887 4888 +1
Partials 401 401
|
|
/ok-to-test |
|
All Times minikube: [ 127.055862 115.152244 125.869987] Average minikube: 122.692698 Averages Time Per Log |
|
All Times minikube: [ 121.223707 123.956422 119.502534] Average minikube: 121.560888 Averages Time Per Log |
|
All Times minikube: [ 124.102523 119.469092 124.420490] Average minikube: 122.664035 Averages Time Per Log |
This fixes two offline bugs. One found by user issue, and one found by adding an integration test for it.
If reference lookups fail due to lack of external connectivity or lack of a locker Docker daemon, transfer the images anyways. The integration test simulates this by providing a bad proxy and docker environment.
If --download-only is specified, we were not downloading drivers, so the subsequently airgapped run would fail.
Fixes #6103 #6116