8000 Add sch_netem kernel module for network emulation by LaumiH · Pull Request #6038 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add sch_netem kernel module for network emulatio 8000 n - #6038

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
LaumiH:master
Dec 10, 2019
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
LaumiH:master

Conversation

@LaumiH
@LaumiH LaumiH commented Dec 9, 2019
Copy link
Copy Markdown
Contributor

Signed-off-by: Laura-Marie Henning laura-marie.henning@stud.h-da.de

Fixes #6033.

Network emulation can e.g. be used for chaos engineering, for which minikube is a valuable environment to test new chaos experiments in. tc qdisc add dev eth0 root netem commands do now work inside minikube and priviledged containers.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @LaumiH!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @LaumiH. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 9, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LaumiH
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaumiH
LaumiH commented Dec 9, 2019
Copy link
Copy Markdown
Contributor Author

I did the CLA and hope it works now, otherwise I will look into it tomorrow.

Signed-off-by: Laura-Marie Henning <laura-marie.henning@stud.h-da.de>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6038 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6038   +/-   ##
=======================================
  Coverage   36.29%   36.29%           
=======================================
  Files         110      110           
  Lines        8235     8235           
=======================================
  Hits         2989     2989           
  Misses       4848     4848           
  Partials      398      398

@LaumiH
LaumiH commented Dec 10, 2019
Copy link
Copy Markdown
Contributor Author

Next try with the CLA, I have signed it just a couple of minutes ago.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 10, 2019
@LaumiH
LaumiH commented Dec 10, 2019
Copy link
Copy Markdown
Contributor Author

/assign @afbjorklund

@tstromberg
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Error: running mkcmp: exit status 1

@tstromberg
tstromberg merged commit 30edc03 into kubernetes:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sch_netem kernel module missing for network emulation (tc netem)

6 participants

0