8000 Use newer gvisor version by wmuizelaar · Pull Request #6000 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Use newer gvisor version - #6000

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
wmuizelaar:wmuizelaar-bump-gvisor
Dec 3, 2019
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
wmuizelaar:wmuizelaar-bump-gvisor

Conversation

@wmuizelaar
Copy link
Copy Markdown
Contributor

The current gvisor version used is quite old, this PR bumps the version to a more recent one.

The current gvisor version used is quite old, this PR bumps the version to a more recent one.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @wmuizelaar!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @wmuizelaar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wmuizelaar
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6000   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files         110      110           
  Lines        8214     8214           
=======================================
  Hits         2972     2972           
  Misses       4851     4851           
  Partials      391      391

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@wmuizelaar
Copy link
Copy Markdown
Contributor Author

/assign @sharifelgamal

@sharifelgamal
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019
@tstromberg
tstromberg merged commit 87af761 into kubernetes:master Dec 3, 2019
@wmuizelaar
wmuizelaar deleted the wmuizelaar-bump-gvisor branch February 10, 2020 08:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.18%. Comparing base (bdf5717) to head (2cc277a).
⚠️ Report is 19238 commits behind head on master.

Additional details 8000 and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6000   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files         110      110           
  Lines        8214     8214           
=======================================
  Hits         2972     2972           
  Misses       4851     4851           
  Partials      391      391           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

< 2C0B /div>
0