8000 Update libmachine to point to latest by sharifelgamal · Pull Request #5877 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Update libmachine to point to latest - #5877

Merged
sharifelgamal merged 3 commits into
kubernetes:masterfrom
sharifelgamal:docker-machine
Nov 10, 2019
Merged

sharifelgamal merged 3 commits into
kubernetes:masterfrom
sharifelgamal:docker-machine

Conversation

@sharifelgamal
@sharifelgamal sharifelgamal commented Nov 9, 2019 •
Copy link
Copy Markdown
Contributor

Should hopefully fix #4802

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2019
@TravisBuddy
Copy link
Copy Markdown

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8502c610-032b-11ea-bbb5-2bfb3cbbfe32

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5877   +/-   ##
======================================
  Coverage    36.5%   36.5%           
======================================
  Files         110     110           
  Lines        8123    8123           
======================================
  Hits         2965    2965           
  Misses       4769    4769           
  Partials      389     389

@sharifelgamal
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 9, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

All Times minikube: [ 178.251057 205.603872 195.463200]
All Times Minikube (PR 5877): [ 184.086065 180.103827 184.399627]

Average minikube: 193.106043
Average Minikube (PR 5877): 182.863173

Averages Time Per Log

+------------------------+-----------+--------------------+
|          LOG           | MINIKUBE  | MINIKUBE (PR 5877) |
+------------------------+-----------+--------------------+
| minikube v             |  0.397762 |           0.377897 |
| Creating kvm2          | 47.686949 |          47.924052 |
| Preparing Kubernetes   | 54.881611 |          56.618676 |
| Pulling images         |  2.829425 |           2.671865 |
| Launching Kubernetes   | 21.913956 |          22.213766 |
| Waiting for: apiserver | 65.396340 |          53.056917 |
+------------------------+-----------+--------------------+

@tstromberg
Copy link
Copy Markdown
Contributor

/ok-to-test

@afbjorklund afbjorklund left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird with all those random changes in go.mod, just for changing some code in libmachine...

@sharifelgamal
Copy link
Copy Markdown
Contributor Author

Yeah I'm not sure what's going on with go.mod, those 3 modules get added every time I run make

@sharifelgamal
sharifelgamal merged commit 0dd3ff1 into kubernetes:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NON_C_DRIVE] when run from C:\ but user config is on different drive

7 participants

0