8000 Replace registry-creds addon ReplicationController with Deployment by reegnz · Pull Request #5586 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Rep 8000 lace registry-creds addon ReplicationController with Deployment - #5586

Merged
sharifelgamal merged 1 commit into
kubernetes:masterfrom
reegnz:replace_replication_controller_with_deployment
Oct 15, 2019
Merged

sharifelgamal merged 1 commit into
kubernetes:masterfrom
reegnz:replace_replication_controller_with_deployment

Conversation

@reegnz
@reegnz reegnz commented Oct 10, 2019
Copy link
Copy Markdown
Contributor

As the official k8s docs state:

Note: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2019
As the official k8s docs state:

> Note: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reegnz
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5586 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5586   +/-   ##
=======================================
  Coverage   36.85%   36.85%           
=======================================
  Files         102      102           
  Lines        7354     7354           
=======================================
  Hits         2710     2710           
  Misses       4293     4293           
  Partials      351      351

@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@sharifelgamal
sharifelgamal merged commit 5e5c042 into kubernetes:master Oct 15, 2019
@reegnz
reegnz deleted the replace_replication_controller_with_deployment branch October 15, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0