Repository navigation
Rep 8000 lace registry-creds addon ReplicationController with Deployment - #5586
sharifelgamal merged 1 commit into
Conversation
|
Hi @reegnz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As the official k8s docs state: > Note: A Deployment that configures a ReplicaSet is now the recommended way to set up replication. https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: reegnz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5586 +/- ##
=======================================
Coverage 36.85% 36.85%
=======================================
Files 102 102
Lines 7354 7354
=======================================
Hits 2710 2710
Misses 4293 4293
Partials 351 351 |
|
@minikube-bot OK to test |
As the official k8s docs state:
https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/