Repository navigation
Add libmachine debug logs back - #5574
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5574 +/- ##
=======================================
Coverage 36.83% 36.83%
=======================================
Files 102 102
Lines 7346 7346
=======================================
Hits 2706 2706
Misses 4289 4289
Partials 351 351 |
|
I see werid error in common.sh |
|
/retest this please |
There was a problem hiding this comment.
I believe this only needs the changes to main.go - can you revert the other files?
Travis tests have failedHey @sharifelgamal, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 3a2b45e0-eab7-11e9-90a0-7556777797a6 |
Fixes #5453
--alsologtostderrwill now always print out all libmachine debug logs, which seems like a reasonable choice.