8000 Add option to configure dnsDomain in kubeAdm by nanikjava · Pull Request #5566 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

A 8000 dd option to configure dnsDomain in kubeAdm - #5566

Merged
medyagh merged 2 commits into
kubernetes:masterfrom
nanikjava:f-fix-4963
Oct 9, 2019
Merged

medyagh merged 2 commits into
kubernetes:masterfrom
nanikjava:f-fix-4963

Conversation

@nanikjava
Copy link
Copy Markdown
Contributor

Fixes #4963

Following are the file changes:

kubeadm.go --> Add DNSDomain as one the field
kubeadm_test.go --> Add new test case to test the dns changes
templates.go --> Add the new DNSDomain into the template

Add new testdata for the kubeadm_test.go

Fixes kubernetes#4963

Following are the file changes:

kubeadm.go --> Add DNSDomain as one the field
kubeadm_test.go --> Add new test case to test the dns changes
templates.go --> Add the new DNSDomain into the template

Add new testdata for the kubeadm_test.go
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 8, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @nanikjava. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
8000 Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nanikjava
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5566 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5566      +/-   ##
==========================================
+ Coverage   36.63%   36.64%   +0.01%     
==========================================
  Files         102      102              
  Lines        7346     7348       +2     
==========================================
+ Hits         2691     2693       +2     
  Misses       4298     4298              
  Partials      357      357
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/kubeadm/templates.go 100% <ø> (ø) ⬆️
pkg/minikube/bootstrapper/kubeadm/kubeadm.go 19.85% <100%> (+0.39%) ⬆️

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and also adding unit tests ! could you add something in the website, either documentation or a tutorial that shows how to use this feature?

@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@nanikjava
Copy link
Copy Markdown
Contributor Author

Thanks for this PR and also adding unit tests ! could you add something in the website, either documentation or a tutorial that shows how to use this feature?

@medyagh Sure can do that, is the website in the docs/ folder of the minikube project ?. Thanks

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 2be8778 Use configured DNS domain in bootstrapper kubeadm templates
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nanikjava
Copy link
Copy Markdown
Contributor Author

Thanks for this PR and also adding unit tests ! could you add something in the website, either documentation or a tutorial that shows how to use this feature?

@medyagh Sure can do that, is the website in the docs/ folder of the minikube project ?. Thanks

Never mind found the folder for the website and added a new file called dns.md under Networking/ folder. Thanks

@medyagh
medyagh commented Oct 9, 2019
Copy link
Copy Markdown
Member

Awesome thanks

@medyagh
medyagh merged commit c0e51aa into kubernetes:master Oct 9, 2019
@medyagh medyagh changed the title Use configured DNS domain in bootstrapper kubeadm templates Add option to configure dnsDomain in kubeAdm Oct 9, 2019
@nanikjava
Copy link
Copy Markdown
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use configured DNS domain in bootstrapper kubeadm templates

6 participants

0