Repository navigation
Add json output for profile list - #555 8000 4
Conversation
|
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
|
/assign @medyagh |
Travis tests have failedHey @woodcockjosh, 1st Buildmake testTravisBuddy Request Identifier: 4cc9a920-e90a-11e9-97f2-39e9ef4a9673 |
e8074d2 to
b7a2683
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
- Coverage 37.23% 37.08% -0.15%
==========================================
Files 103 103
Lines 7528 7560 +32
==========================================
+ Hits 2803 2804 +1
- Misses 4352 4383 +31
Partials 373 373
|
b7a2683 to
7bc2012
Compare
|
This is great ! would be lovely to have this for other commands (in separate PRs) like minikube status |
|
/retest this please |
|
/retest |
|
@woodcockjosh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@medyagh should I take it out of WIP status or do you know of a way I could add a test? |
|
@woodcockjosh I am okay with this being merged, however it would be absolutely beautiful if we add a test for it, you could add a cheap test here just basicly do porfile list and then make sure the output is a valid json. you can use either of these to see the content of the result putput |
|
/ok-to-test |
|
@medyagh I will have time to try to add a test tomorrow |
|
@medyagh this is complete |
1c78eff to
d42e296
Compare
d42e296 to
d758672
Compare
|
Thank you! |
Related to discussion in #5493 but does not resolve #5493
Show profile list help
Before
Command:
Output:
After
Command:
Output:
Show profile list default
Before
Command:
Output
After
Command:
Output
Show profile list as json
Before
Command:
Output
After
Command:
Output
{"invalid":[],"valid":[{"Name":"cl","Config":{"MachineConfig":{"KeepContext":false,"EmbedCerts":false,"MinikubeISO":"https://storage.googleapis.com/minikube/iso/minikube-v1.4.0.iso","Memory":6500,"CPUs":2,"DiskSize":20000,"VMDriver":"virtualbox","ContainerRuntime":"docker","HyperkitVpnKitSock":"","HyperkitVSockPorts":[],"DockerEnv":null,"InsecureRegistry":null,"RegistryMirror":null,"HostOnlyCIDR":"192.168.99.1/24","HypervVirtualSwitch":"","KVMNetwork":"default","KVMQemuURI":"qemu:///system","KVMGPU":false,"KVMHidden":false,"DockerOpt":null,"DisableDriverMounts":false,"NFSShare":[],"NFSSharesRoot":"/nfsshares","UUID":"","NoVTXCheck":false,"DNSProxy":false,"HostDNSResolver":true},"KubernetesConfig":{"KubernetesVersion":"v1.16.0","NodeIP":"192.168.99.138","NodePort":8443,"NodeName":"minikube","APIServerName":"minikubeCA","APIServerNames":null,"APIServerIPs":null,"DNSDomain":"cluster.local","ContainerRuntime":"docker","CRISocket":"","NetworkPlugin":"","FeatureGates":"","ServiceCIDR":"10.96.0.0/12","ImageRepository":"","ExtraOptions":null,"ShouldLoadCachedImages":true,"EnableDefaultCNI":false}}},{"Name":"minikube","Config":{"MachineConfig":{"KeepContext":false,"EmbedCerts":false,"MinikubeISO":"https://storage.googleapis.com/minikube/iso/minikube-v1.3.0.iso","Memory":6500,"CPUs":2,"DiskSize":20000,"VMDriver":"virtualbox","ContainerRuntime":"docker","HyperkitVpnKitSock":"","HyperkitVSockPorts":[],"DockerEnv":null,"InsecureRegistry":null,"RegistryMirror":null,"HostOnlyCIDR":"192.168.99.1/24","HypervVirtualSwitch":"","KVMNetwork":"default","KVMQemuURI":"qemu:///system","KVMGPU":false,"KVMHidden":false,"DockerOpt":null,"DisableDriverMounts":false,"NFSShare":[],"NFSSharesRoot":"/nfsshares","UUID":"","NoVTXCheck":false,"DNSProxy":false,"HostDNSResolver":true},"KubernetesConfig":{"KubernetesVersion":"v1.14.7","NodeIP":"192.168.99.188","NodePort":8443,"NodeName":"minikube","APIServerName":"minikubeCA","APIServerNames":null,"APIServerIPs":null,"DNSDomain":"cluster.local","ContainerRuntime":"docker","CRISocket":"","NetworkPlugin":"","FeatureGates":"","ServiceCIDR":"10.96.0.0/12","ImageRepository":"","ExtraOptions":null,"ShouldLoadCachedImages":true,"EnableDefaultCNI":false}}}]}TODO Add test
Need someone to show me how I could add a test. Otherwise this is ready to merge.