Repository navigation
Conversation
|
Hi @11janci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 11janci The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Travis tests have failedHey @11janci, 1st Buildmake testTravisBuddy Request Identifier: f4afba20-da65-11e9-b256-8f6de709717d |
4c4179b to
347d4f9
Compare
347d4f9 to
fdf2dcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #5400 +/- ##
=========================================
Coverage ? 37.69%
=========================================
Files ? 103
Lines ? 7616
Branches ? 0
=========================================
Hits ? 2871
Misses ? 4368
Partials ? 377 |
|
@minikube-bot OK to test |
fdf2dcd to
67a42f2
Compare
|
/retest |
|
@11janci: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9bcff48 to
9218f12
Compare
|
/retest |
|
@11janci: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9218f12 to
8b0cb3e
Compare
|
@minikube-bot OK to test |
b8492bf to
ad13cbb
Compare
|
Change looks good, but it isn't clear to me what issue this is fixing. Can you add a description as to why this change is happening? |
|
@tstromberg It is for #5144 and #3318 (updated the PR desc). However I'm hitting a wall testing it. Can't figure out why the tests here are failing, am trying to revert changes to see where it breaks. Also, I'm not able to test it locally without the minikube ISO and can't build the ISO (is failing on my mac) 😒 I should be able to get it from https://storage.googleapis.com/minikube-builds/5400/minikube-testing.iso, but for that I need the tests here to pass 🤕 |
|
@11janci do you mind providing examples ? maybe in the PR descrption and also add related docs in the site? |
|
@medyagh you mean examples of usage? This is a work in progress and I'd like to get it working first, however don't have the capacity to work on it right now :/ |
@11janci If you need help in running the testing on local machine happy to help |
|
Need any help with this? The integration test looks good. I just don't understand exactly what the end goal is, and how far along this PR is at achieving it. |
|
@tstromberg, @ALL yeah as mentioned above, I currently don't have the capacity to work on this (for at least another 2 months). If anybody wants to take over, feel free to pull my changes and finish it off. The end goal is to make the dynamic PV path I was adding and removing my changes as I was trying to test it so check out my previous commits, especially the first one. |
|
Thank you for the update! I'm closing this PR until someone is ready to take a look at it again. Please feel free to re-open it once you or someone else has time. Related: #6156 |
For #5144 & #3318