Repository navigation
Move program 8000 data files onto persistent storage - #5032
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
haven't reviewed yet but form the smells of it I could tell this is amazing ! |
|
one lint |
|
the fail for none test seems to be related to this PR: as I haven't seen it else where: |
|
/retest this please |
|
Current failures:
I suspect that these are flakes, but it worries me to see multiple TestVersionUpgrade failures, especially as the etcd folder has moved, so I will confirm locally. |
|
| // AddonsPath is the default path of the addons configuration | ||
| const AddonsPath = "/etc/kubernetes/addons" | ||
| // GetProfileFile returns the Minikube profile config file | ||
| func GetProfileFile(profile string, miniHome ...string) string { |
There was a problem hiding this comment.
Maybe rename to ProfileFile(...)
There was a problem hiding this comment.
These unused functions must have been added by a bad merge. Removing.
| // FilesPath is the default path of files | ||
| const FilesPath = "/files" | ||
| // GetProfilePath returns the Minikube profile path of config file | ||
| func GetProfilePath(profile string, miniHome ...string) string { |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: bee3bcf0-c473-11e9-9094-9f1a962f5d6e |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 35c38fd0-c474-11e9-9094-9f1a962f5d6e |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 71084a90-c474-11e9-9094-9f1a962f5d6e |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 6189cf70-c475-11e9-9094-9f1a962f5d6e |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: bc99eca0-c476-11e9-9094-9f1a962f5d6e |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 28a41250-c480-11e9-9094-9f1a962f5d6e |
|
awww thanks @TravisBuddy |
|
Unrelated flakes, merging. |
With this PR,
minikube startis about 2 seconds slower on my MacBook Pro. There will be a follow-up PR that substantially increases performance by reusing these files rather than overwriting them each run, but I wanted to keep this PR on the smaller side.Notable Changes
/var/lib/minikube/binaries(persistent) rather than/usr/bin/var/lib/minikube/images(persistent) rather than/tmp/var/lib/minikube/etcdinstead of/data/minikube- leaving/dataentirely for user data.sshrunner.Copyno longer removes targets, leaving room for the future persistence PR. It's also been simplified using errgroup.constants.AddonsPath -> constants.GuestAddonsDir)This PR closes #4097 and #3718
This PR helps with #3760 - but more work remains.