Repository navigation
Upgrade addons to use apps/v1 instead of extensions/v1beta1 - #5028
Conversation
|
Hi @reegnz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: reegnz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Also I guess this means with this change minikube plugins won't support kubernetes <1.9 anymore. |
|
/ok-to-test |
|
@minikube-bot OK to test |
There was a problem hiding this comment.
Looks good (assuming tests pass)
|
Tests are failing but I don't see anything that could have been caused by these changes. :( |
|
/retest this please |
|
this seems to consistantly break all the tests for : |
extensions/v1beta1 are deprecated and will not be served with kubernetes 1.16 anymore. For Deployment,DaemonSet and StatefulSet the apps/v1 api has been present since kubernetes 1.9. See following blog post for details: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
|
@medyagh it turns out labelselectors were not mandatory for deployments and daemonsets in extensions/v1beta1, that's what caused the failing test case. I adjusted the selectors in some other parts as well that don't have any test assertions present. |
|
Looks good. Thank you! |
extensions/v1beta1 are deprecated and will not be served with kubernetes 1.16
anymore.
For Deployment,DaemonSet and StatefulSet the apps/v1 api has been present
since kubernetes 1.9.
See following blog post for details:
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/