8000 Upgrade addons to use apps/v1 instead of extensions/v1beta1 by reegnz · Pull Request #5028 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Upgrade addons to use apps/v1 instead of extensions/v1beta1 - #5028

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
reegnz:upgrade-deprecated-api-references
Aug 26, 2019
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
reegnz:upgrade-deprecated-api-references

Conversation

@reegnz
@reegnz reegnz commented Aug 9, 2019
Copy link
Copy Markdown
Contributor

extensions/v1beta1 are deprecated and will not be served with kubernetes 1.16
anymore.

For Deployment,DaemonSet and StatefulSet the apps/v1 api has been present
since kubernetes 1.9.

See following blog post for details:
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reegnz
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@reegnz
reegnz commented Aug 9, 2019
Copy link
Copy Markdown
Contributor Author

Also I guess this means with this change minikube plugins won't support kubernetes <1.9 anymore.

@micw523
micw523 commented Aug 9, 2019
Copy link
Copy Markdown

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@tstromberg tstromberg left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (assuming tests pass)

@reegnz
reegnz commented Aug 9, 2019
Copy link
Copy Markdown
Contributor Author

Tests are failing but I don't see anything that could have been caused by these changes. :(

@medyagh
medyagh commented Aug 14, 2019
Copy link
Copy Markdown
Member

/retest this please

@medyagh
medyagh commented Aug 14, 2019
Copy link
8000
Copy Markdown
Member

this seems to consistantly break all the tests for :
for

      --- FAIL: TestFunctional/group/Registry (350.72s)
            fn_addons.go:211: waiting for registry-proxy pods: timed out waiting for the condition

@medyagh medyagh changed the title Upgrade addons to use apps/v1 instead of extensions/v1beta1 wip (failing test): Upgrade addons to use apps/v1 instead of extensions/v1beta1 Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2019
@medyagh medyagh changed the title wip (failing test): Upgrade addons to use apps/v1 instead of extensions/v1beta1 wip (failing registery test): Upgrade addons to use apps/v1 instead of extensions/v1beta1 Aug 14, 2019
extensions/v1beta1 are deprecated and will not be served with kubernetes 1.16
anymore.

For Deployment,DaemonSet and StatefulSet the apps/v1 api has been present
since kubernetes 1.9.

See following blog post for details:
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2019
@reegnz
reegnz commented Aug 26, 2019
Copy link
Copy Markdown
Contributor Author

@medyagh it turns out labelselectors were not mandatory for deployments and daemonsets in extensions/v1beta1, that's what caused the failing test case.

I adjusted the selectors in some other parts as well that don't have any test assertions present.

@reegnz reegnz changed the title wip (failing registery test): Upgrade addons to use apps/v1 instead of extensions/v1beta1 Upgrade addons to use apps/v1 instead of extensions/v1beta1 Aug 26, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2019
@tstromberg
Copy link
Copy Markdown
Contributor

Looks good. Thank you!

@tstromberg
tstromberg merged commit c26281b into kubernetes:master Aug 26, 2019
@reegnz
reegnz deleted the upgrade-deprecated-api-references branch August 27, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that 539F is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0