8000 Fixed the template for dashboard output by blueelvis · Pull Request #5004 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fixed the template for dashboard output - #5004

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
blueelvis:5002-fix-dashboard-regression
Aug 7, 2019
Merged

k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
blueelvis:5002-fix-dashboard-regression

Conversation

@blueelvis
Copy link
Copy Markdown
Contributor

Fixes regression #5002

-Pranav

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @blueelvis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2019
@medyagh
medyagh commented Aug 7, 2019
Copy link
Copy Markdown
Member

Thanks for this quick PR

@RA489
RA489 commented Aug 7, 2019
Copy link
Copy Markdown

@minikube-bot Ok to test

@RA489
RA489 commented Aug 7, 2019
Copy link
Copy Markdown

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blueelvis, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@k8s-ci-robot
k8s-ci-robot merged commit ad0eec8 into kubernetes:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0