Repository navigation
Added a new command: profile list - #4811
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Could you add a unit test of profile.go? Just a basic one that makes sure you can find all the profiles in a given directory? |
tstromberg
suggested changes
Jul 18, 2019
Contributor
There was a problem hiding this comment.
Looks good. Minor nits.
Member
Author
|
/retest this please |
Contributor
|
The test failure looks to be the unrelated registry failure we've been seeing. LGTM. |
sharifelgamal
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a new command to minikube, profile list that looks like this
if there be invalid profiles it will warn this way:
it will also print an err to the logs, if there is a not valid config profile (empty dir)